I found out that when I write my filename output using [fRunType], it writes my runType using uppercase letters. I don’t feel very comfortable that this particular member breaks my personal convention that the first letter is upper, and other letters are low in the construction of the string. Is there a reason to make it upper and assign the upper result to this member?
If I keep the original low-up pattern assigned by the user, by modifying the code and removing the ToUpper function in TRestRun::BeginOfInitProcess, will be ok? Or there is any comparison somewhere else that needs to be made ToUpper? I think that should not be a problem by calling ToUpper directly in the comparison.
When setting up pandax’s database, we pre-define the run types using pure upper letters, e.g. “PHYSICS_DM”, “CALIBRATION”, “HW_DEBUG”, etc. So I followed this convention to make REST run type all upper. However, it seems that PascalCase is a more commom naming convention for the database, which is as you prefer. Maybe we can setup a convention for REST later on.