System : Linux, MacOs, Windows?
REST version : v2.2.X
In V2.2 we defined alternative methods but with input of sealed xml class, instead of strings. e.g.
GetKeyStructure()
→ GetElement()
, ElementToString()
while(GetKeyDefinition())
→ while (e != NULL){e = e->NextSiblingElement();}
I think the old GetKeyStructure()
should better placed inside TRestStringHelper, and the current metadata classes should gradually migrate to the new interface. Then, in TRestMetadata, we can remove the old methods. This will make our code cleaner and more uniform, since both are using a same interface(TRestMetadata and TRestRun are already using the new interface).
The main classes to update are TRestReadout, TRestG4Metadata and TRestAnalysisPlot.