REST version : v2.2.10_dev
I was about to commit the changes I had made to ReadoutEventViewer to rejuvenate the viewer (which has not been working since a while, see: “Seg. fault in "REST_ViewReadoutEvent"”). This, after I had made some effort to comply w/ the newly implemented coding style. Only to find that the corresponding files were updated in the mean time, w/ the coding style changed again, in another direction.
I think the idea of changing the coding style on a part of the software which is not stable is an exceedingly bad one. When the software is mature and stable and proved to work, OK. And then let’s reserve the implementation of the new coding style to that part of the software only.
In principle, the idea is that we adopt a coding style, fixed by clang-format, and then somehow the coding style fixed by clang-format will remain, let’s say, stable. I imagine the problems you are experiencing are related to the transition?
I understand this might introduce issues if you have introduced changes in a non clang-format styled code. It seems to me that is the main issue here? In any case, you might run clang-format to your modified files and get to observe the differences.
Now the whole repository should be coherent with clang-format.
Personally, I see the styling with clang-format practise is a quite extended one, and I don’t get why it should only be applied to a part of the repository. Once you integrate it with emacs, for example, it should automatically do few cosmetics at each file save. And particularly, in my case I don’t see major problems.
Still, I see that most of people coding in the repository should agree to this. We may discuss that in a future meeting. To understand this and other problems during development.